[ 
https://issues.apache.org/jira/browse/HBASE-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772143#comment-13772143
 ] 

Jeffrey Zhong commented on HBASE-9581:
--------------------------------------

The latest 
patch(https://issues.apache.org/jira/secure/attachment/12604072/HBASE-9581.patch)
 looks good to me. Thanks.

[~adityakishore] The extra close may cause race condition such as one test case 
closes the shared HBaseAdmin instance, its connection get really closed and 
later test case will fail if it tries to use the connection instance for RPC 
calls. With your patch, we will not see the issue as we skip close but it's a 
good thing to clean the code(minor thing though). 

                
> Few tests broken since HBASE-9551
> ---------------------------------
>
>                 Key: HBASE-9581
>                 URL: https://issues.apache.org/jira/browse/HBASE-9581
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>              Labels: tests
>             Fix For: 0.96.0
>
>         Attachments: HBASE-9581_combined.patch, hbase-9581.patch, 
> HBASE-9581.patch, HBASE-9581.patch
>
>
> Few test cases, for example 
> {{org.apache.hadoop.hbase.client.TestSnapshotFromClient}} hangs since the 
> commit for HBASE-9551

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to