[ 
https://issues.apache.org/jira/browse/HBASE-9420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13775739#comment-13775739
 ] 

Enis Soztutar commented on HBASE-9420:
--------------------------------------

HBASE-8755 changes syncedTillHere as well, and it seems that it seems to 
synchronize on it, before the update. I have to spend some time to grok the 
whole patch still, but if we can prove that that model is better, we might as 
well let that overtake this issue. 
                
> Math.max() on syncedTillHere lacks synchronization
> --------------------------------------------------
>
>                 Key: HBASE-9420
>                 URL: https://issues.apache.org/jira/browse/HBASE-9420
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Trivial
>             Fix For: 0.98.0
>
>         Attachments: 9420-v1.txt, 9420-v2.txt
>
>
> In FSHlog#syncer(), around line 1080:
> {code}
>       this.syncedTillHere = Math.max(this.syncedTillHere, doneUpto);
> {code}
> Assignment to syncedTillHere after computing max value is not protected by 
> proper synchronization.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to