[
https://issues.apache.org/jira/browse/HBASE-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778029#comment-13778029
]
stack commented on HBASE-9657:
------------------------------
Would like some proof. I see notice that this patch 'passes'. None that the
failure was reproduced. Also, the allusion is arcane, cryptic. Even for those
who are doing their best trying to keep up, this looks like an
in-from-left-fielder. Noise. A distraction.
> Race condition in low replication checking and FSHLog#rollWriter()
> ------------------------------------------------------------------
>
> Key: HBASE-9657
> URL: https://issues.apache.org/jira/browse/HBASE-9657
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Trivial
> Attachments: 9657-v1.txt, 9657-v2.txt
>
>
> In FSHLog#syncer(), we have this comment:
> {code}
> // TODO: preserving the old behavior for now, but this check is
> strange. It's not
> // protected by any locks here, so for all we know rolling locks
> might start
> // as soon as we enter the "if". Is this best-effort optimization
> check?
> if (!this.logRollRunning) {
> checkLowReplication();
> {code}
> The implication is that checkLowReplication() may be running when
> FSHLog#rollWriter() is also running.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
