[
https://issues.apache.org/jira/browse/HBASE-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778111#comment-13778111
]
Hadoop QA commented on HBASE-9657:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12605108/TEST-org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.xml.gz
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7379//console
This message is automatically generated.
> Race condition in low replication checking and FSHLog#rollWriter()
> ------------------------------------------------------------------
>
> Key: HBASE-9657
> URL: https://issues.apache.org/jira/browse/HBASE-9657
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Trivial
> Attachments: 9657-v1.txt, 9657-v2.txt,
> TEST-org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.xml.gz
>
>
> In FSHLog#syncer(), we have this comment:
> {code}
> // TODO: preserving the old behavior for now, but this check is
> strange. It's not
> // protected by any locks here, so for all we know rolling locks
> might start
> // as soon as we enter the "if". Is this best-effort optimization
> check?
> if (!this.logRollRunning) {
> checkLowReplication();
> {code}
> The implication is that checkLowReplication() may be running when
> FSHLog#rollWriter() is also running.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
