[ 
https://issues.apache.org/jira/browse/HBASE-9137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790682#comment-13790682
 ] 

Andrew Purtell commented on HBASE-9137:
---------------------------------------

The changes to ProtobufLog{Reader,Writer} leak out tag implementation details 
into HLog. Should this be something the cell codec can handle? Maybe a 
CompressionContext can hold more than one dictionary? It looks fine to me 
otherwise, I'm +0, just wondering if the above can be considered now without 
too much trouble.

> Add Tag dictionary in WAL compression
> -------------------------------------
>
>                 Key: HBASE-9137
>                 URL: https://issues.apache.org/jira/browse/HBASE-9137
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.98.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 0.98.0
>
>         Attachments: HBASE-9137.patch, HBASE-9137_V2.patch
>
>
> We can add tag dictionary like we have one for rowdictionary, 
> familydictionary.  But this has to be done after stabilizing HBASE-7391.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to