[
https://issues.apache.org/jira/browse/HBASE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809560#comment-13809560
]
stack commented on HBASE-9862:
------------------------------
I tried it in my little harness and it doesn't break anything at least.
Patch application failed because you added something I had -- catching
Thowables.
+ } catch (Throwable t) {
+ // This should not happen. Let's log & retry anyway.
+ LOG.warn("#" + id + ", Caught throwable while calling. This is
unexpected." +
+ " Retrying. Server is " + loc.getServerName() + ",
tableName=" + tableName, t);
+ receiveGlobalFailure(initialActions, multiAction, loc,
numAttempt, t,
+ errorsByServer);
return;
The above should be LOG.error because it is not supposed to happen (though it
did for me when making up my harness getting stuff wrong and probably for you
when you were refactoring -- it is too easy for exceptions to be suppressed in
this stuff....).
We don't usually run w/ asserts:
+ assert responses != null;
.. perhaps in testing, I don't recall.
Let me mess some more w/ it in place before I give a +1... let me manufacture
the errors you address here.
> manage error per server and per region in the protobuffed client
> ----------------------------------------------------------------
>
> Key: HBASE-9862
> URL: https://issues.apache.org/jira/browse/HBASE-9862
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.98.0, 0.96.0
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Fix For: 0.98.0, 0.96.1
>
> Attachments: 9862.v2.patch
>
>
> The patch does not change anything else than the description says. The
> changes are about extracting the common paths.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
