[ 
https://issues.apache.org/jira/browse/HBASE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809588#comment-13809588
 ] 

Nicolas Liochon commented on HBASE-9862:
----------------------------------------

For the assert, I've used them as a kind of documentation (I use IllegalState 
when I fear it could occur in production). When we run the tests they are 
activated. I can remove them, or replace them with an IllegalArgumentException.

bq. assuming it's just a refactoring for the most part it should be good.
Yes, the logic is not supposed to change (if I did it well :-) ). The changes 
are 90% code extraction. The remaining 10% took me a while...

Thanks for the comments.

> manage error per server and per region in the protobuffed client
> ----------------------------------------------------------------
>
>                 Key: HBASE-9862
>                 URL: https://issues.apache.org/jira/browse/HBASE-9862
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: 9862.v2.patch
>
>
> The patch does not change anything else than the description says. The 
> changes are about extracting the common paths.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to