[
https://issues.apache.org/jira/browse/HBASE-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820268#comment-13820268
]
Ted Yu commented on HBASE-9959:
-------------------------------
lgtm.
{code}
+ public Put(ByteBuffer row, long ts) {
+ checkRow(row);
+ this.row = new byte[row.remaining()];
+ row.get(this.row);
+ this.ts = ts;
+ if (ts < 0) {
+ throw new IllegalArgumentException("Timestamp cannot be negative. ts=" +
ts);
{code}
Consider moving the check of ts up - maybe following checkRow(row).
> Remove some array copy - server side
> ------------------------------------
>
> Key: HBASE-9959
> URL: https://issues.apache.org/jira/browse/HBASE-9959
> Project: HBase
> Issue Type: Bug
> Components: Protobufs, regionserver
> Affects Versions: 0.98.0, 0.96.0
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Fix For: 0.98.0, 0.96.1
>
> Attachments: 9959.v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
