[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826131#comment-13826131 ]
Hadoop QA commented on HBASE-8465: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614520/HBASE-8465-v6.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 10 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7924//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7924//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7924//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7924//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7924//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7924//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7924//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7924//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7924//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7924//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7924//console This message is automatically generated. > Auto-drop rollback snapshot for snapshot restore > ------------------------------------------------ > > Key: HBASE-8465 > URL: https://issues.apache.org/jira/browse/HBASE-8465 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Matteo Bertozzi > Fix For: 0.98.0, 0.96.1 > > Attachments: 8465-trunk-v1.txt, 8465-trunk-v2.txt, > HBASE-8465-v3.patch, HBASE-8465-v4.patch, HBASE-8465-v5.patch, > HBASE-8465-v6.patch > > > Below is an excerpt from snapshot restore javadoc: > {code} > * Restore the specified snapshot on the original table. (The table must be > disabled) > * Before restoring the table, a new snapshot with the current table state > is created. > * In case of failure, the table will be rolled back to the its original > state. > {code} > We can improve the handling of rollbackSnapshot in two ways: > 1. give better name to the rollbackSnapshot (adding > {code}'-for-rollback-'{code}). Currently the name is of the form: > String rollbackSnapshot = snapshotName + "-" + > EnvironmentEdgeManager.currentTimeMillis(); > 2. drop rollbackSnapshot at the end of restoreSnapshot() if the restore is > successful. We can introduce new config param, named > 'hbase.snapshot.restore.drop.rollback', to keep compatibility with current > behavior. -- This message was sent by Atlassian JIRA (v6.1#6144)