[ 
https://issues.apache.org/jira/browse/HBASE-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827436#comment-13827436
 ] 

Liang Xie commented on HBASE-10010:
-----------------------------------

I added some debug logs in syncer(long) before/after tempWriter.sync();

before :
2013-11-19,15:42:41,580 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:196921us
2013-11-19,15:47:52,686 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:19665us
2013-11-19,15:48:16,270 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:21565us
2013-11-19,15:48:43,686 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:21860us
2013-11-19,15:49:07,050 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:27612us
2013-11-19,15:49:34,785 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:21311us
2013-11-19,15:50:04,077 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:20829us
2013-11-19,15:50:29,836 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:21424us
2013-11-19,15:50:59,168 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:21299us
2013-11-19,15:51:24,384 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:38065us
2013-11-19,15:51:51,250 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:22940us
2013-11-19,15:52:18,997 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:204917us
2013-11-19,15:53:00,256 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:29913us
2013-11-19,15:53:48,317 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:293027us
2013-11-19,15:54:39,473 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:279183us
2013-11-19,15:55:27,519 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:73038us
2013-11-19,15:56:10,762 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:23200us
2013-11-19,15:56:58,304 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:50298us
2013-11-19,15:57:48,976 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:30899us
2013-11-19,15:58:29,328 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:21863us
2013-11-19,15:59:09,681 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:32979us
2013-11-19,15:59:52,697 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:50621us
2013-11-19,16:00:39,956 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:365199us
2013-11-19,16:01:30,344 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:38628us
2013-11-19,16:02:16,520 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:105847us

after applied this patch:

2013-11-19,17:23:24,546 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:1819us
2013-11-19,17:27:11,566 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:1207us
2013-11-19,17:27:52,424 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:2017us
2013-11-19,17:28:42,973 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:1735us
2013-11-19,17:29:29,495 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:929us
2013-11-19,17:30:20,270 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:1220us
2013-11-19,17:31:17,437 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:2685us
2013-11-19,17:32:13,032 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:30865us
2013-11-19,17:33:05,483 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:1540us
2013-11-19,17:33:50,325 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:1448us
2013-11-19,17:34:30,508 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:1675us
2013-11-19,17:35:01,440 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:1279us
2013-11-19,17:35:29,878 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:1561us
2013-11-19,17:36:02,552 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:1253us
2013-11-19,17:36:30,942 INFO org.apache.hadoop.hbase.regionserver.wal.HLog: 
FirstSync cost:889us

> eliminate the put latency spike on the new log file beginning
> -------------------------------------------------------------
>
>                 Key: HBASE-10010
>                 URL: https://issues.apache.org/jira/browse/HBASE-10010
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.94.13
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>
> In deed, the original finding came from fb, see HBASE-6813 for detailed 
> discussion.
> Through this improvement doesn't expect obvious gain on 95th or 99th latency, 
> it still could make the response time more stable to me.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to