[ 
https://issues.apache.org/jira/browse/HBASE-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829690#comment-13829690
 ] 

stack commented on HBASE-10010:
-------------------------------

Patch looks good to me.  Add TODO for compressed writing case if you want and 
we can come back and do that later.  Suggest that 
'Arrays.equals(key.getEncodedRegionName(), HLog.DUMMY_REGION)' be put inside a 
static method in /HLogUtil.java since it is repeated in a few places.

> eliminate the put latency spike on the new log file beginning
> -------------------------------------------------------------
>
>                 Key: HBASE-10010
>                 URL: https://issues.apache.org/jira/browse/HBASE-10010
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.94.13
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>         Attachments: HBase-10010-0.94-v2.txt, HBase-10010-0.94.txt, 
> HBase-10010-trunk.txt
>
>
> In deed, the original finding came from fb, see HBASE-6813 for detailed 
> discussion.
> Through this improvement doesn't expect obvious gain on 95th or 99th latency, 
> it still could make the response time more stable to me.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to