[
https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058099#comment-13058099
]
[email protected] commented on HBASE-4048:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/984/#review936
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<https://reviews.apache.org/r/984/#comment2013>
Would an abstract class be more appropriate here ?
src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
<https://reviews.apache.org/r/984/#comment2012>
White space.
- Ted
On 2011-06-30 21:16:28, Andrew Purtell wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/984/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-30 21:16:28)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Users should be able to pass configuration options to coprocessors. These
options should be applied at load time.
bq.
bq. - For system coprocessors, just use the configuration of the container.
bq.
bq. - Extend table coprocessor load specification to allow arbitrary key-value
pairs at the end (<key>=<value>{,}).
bq.
bq. Also fixes the outstanding issue where coprocessor priority is supposed to
be an integer range but is constrained by the Coprocessor.Priority enum to 4
values.
bq.
bq.
bq. This addresses bug HBASE-4048.
bq. https://issues.apache.org/jira/browse/HBASE-4048
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
c2ea442
bq.
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
ac5387a
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
5bae05a
bq. src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
4800bea
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
a98117f
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
796742c
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
58a09f8
bq.
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
969b1f3
bq.
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java
0cdf7d1
bq.
bq. Diff: https://reviews.apache.org/r/984/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.
bq.
bq.
bq. Thanks,
bq.
bq. Andrew
bq.
bq.
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These
> options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value
> pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
