[
https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058659#comment-13058659
]
[email protected] commented on HBASE-4048:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/984/
-----------------------------------------------------------
(Updated 2011-07-01 17:19:11.368248)
Review request for hbase.
Changes
-------
Lift the four Priority constants to Coprocessor.
Clean up extraneous whitespace.
Summary
-------
Users should be able to pass configuration options to coprocessors. These
options should be applied at load time.
- For system coprocessors, just use the configuration of the container.
- Extend table coprocessor load specification to allow arbitrary key-value
pairs at the end (<key>=<value>{,}).
Also fixes the outstanding issue where coprocessor priority is supposed to be
an integer range but is constrained by the Coprocessor.Priority enum to 4
values.
This addresses bug HBASE-4048.
https://issues.apache.org/jira/browse/HBASE-4048
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
ac5387a
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
5bae05a
src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
4800bea
src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
9c4916f
src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
796742c
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
58a09f8
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
969b1f3
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
0435326
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java
0cdf7d1
Diff: https://reviews.apache.org/r/984/diff
Testing
-------
Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.
Thanks,
Andrew
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These
> options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value
> pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
