[
https://issues.apache.org/jira/browse/HBASE-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878418#comment-13878418
]
Hadoop QA commented on HBASE-10395:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12624298/HBASE-10395-0.94-v1.patch
against trunk revision .
ATTACHMENT ID: 12624298
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8493//console
This message is automatically generated.
> endTime won't be set in VerifyReplication if startTime is not set
> -----------------------------------------------------------------
>
> Key: HBASE-10395
> URL: https://issues.apache.org/jira/browse/HBASE-10395
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, Replication
> Affects Versions: 0.94.16
> Reporter: cuijianwei
> Assignee: cuijianwei
> Priority: Minor
> Attachments: HBASE-10395-0.94-v1.patch
>
>
> In VerifyReplication, we may set startTime and endTime to restrict the data
> to verfiy. However, the endTime won't be set in the program if we only pass
> endTime without startTime in command line argument. The reason is the
> following code:
> {code}
> if (startTime != 0) {
> scan.setTimeRange(startTime,
> endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime);
> }
> {code}
> The code will ignore endTime setting when not passing startTime in command
> line argument. Another place needs to improvement is the help message as
> follows:
> {code}
> System.err.println(" stoprow end of the row");
> {code}
> However, the program actually use "endrow" to parse the arguments:
> {code}
> final String endTimeArgKey = "--endtime=";
> if (cmd.startsWith(endTimeArgKey)) {
> endTime = Long.parseLong(cmd.substring(endTimeArgKey.length()));
> continue;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
