[
https://issues.apache.org/jira/browse/HBASE-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878862#comment-13878862
]
Ted Yu commented on HBASE-10395:
--------------------------------
+1
[~apurtell]:
Do you want this in 0.98 ?
> endTime won't be set in VerifyReplication if startTime is not set
> -----------------------------------------------------------------
>
> Key: HBASE-10395
> URL: https://issues.apache.org/jira/browse/HBASE-10395
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, Replication
> Affects Versions: 0.94.16
> Reporter: cuijianwei
> Assignee: cuijianwei
> Priority: Minor
> Attachments: HBASE-10395-0.94-v1.patch, HBASE-10395-0.94-v2.patch,
> HBASE-10395-0.94-v3.patch, HBASE-10395-trunk-v1.patch,
> HBASE-10395-trunk-v2.patch, HBASE-10395-trunk-v3.patch
>
>
> In VerifyReplication, we may set startTime and endTime to restrict the data
> to verfiy. However, the endTime won't be set in the program if we only pass
> endTime without startTime in command line argument. The reason is the
> following code:
> {code}
> if (startTime != 0) {
> scan.setTimeRange(startTime,
> endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime);
> }
> {code}
> The code will ignore endTime setting when not passing startTime in command
> line argument. Another place needs to improvement is the help message as
> follows:
> {code}
> System.err.println(" stoprow end of the row");
> {code}
> However, the program actually use "endrow" to parse the arguments:
> {code}
> final String endTimeArgKey = "--endtime=";
> if (cmd.startsWith(endTimeArgKey)) {
> endTime = Long.parseLong(cmd.substring(endTimeArgKey.length()));
> continue;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
