[jira] [Commented] (HBASE-10408) Intermittent TestDistributedLogSplitting#testLogReplayForDisablingTable failure

[Andrew Purtell (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881222#comment-13881222
 ] 

Andrew Purtell commented on HBASE-10408:
----------------------------------------

Ted, can you explain how the test is now fixed?

AFAIK, this "goto" isn't necessary:
{code}
--- 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
  (revision 1561083)
+++ 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
  (working copy)
@@ -739,16 +739,15 @@
     HRegionServer hrs = null;
     boolean hasRegionsForBothTables = false;
     String tableName = null;
+    OUTER:
     for (int i = 0; i < NUM_RS; i++) {
       tableName = null;
       hasRegionsForBothTables = false;
-      boolean isCarryingMeta = false;
       hrs = rsts.get(i).getRegionServer();
       regions = ProtobufUtil.getOnlineRegions(hrs);
       for (HRegionInfo region : regions) {
-        if (region.isMetaRegion()) {
-          isCarryingMeta = true;
-          break;
+        if (region.getTable().isSystemTable()) {
+          continue OUTER;
         }
         if (tableName != null &&
             !tableName.equalsIgnoreCase(region.getTable().getNameAsString())) {
{code}

> Intermittent TestDistributedLogSplitting#testLogReplayForDisablingTable 
> failure
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-10408
>                 URL: https://issues.apache.org/jira/browse/HBASE-10408
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 10408-v1.txt, 10408-v2.txt, 
> TestDistributedLogSplitting.out, 
> testDistributedLogSplitting-disablingTable.html
>
>
> Here was the assertion failure:
> {code} java.lang.AssertionError: expected:&lt;1000> but was:&lt;0> at 
> org.junit.Assert.fail(Assert.java:88) at 
> org.junit.Assert.failNotEquals(Assert.java:743) at 
> org.junit.Assert.assertEquals(Assert.java:118) at 
> org.junit.Assert.assertEquals(Assert.java:555) at 
> org.junit.Assert.assertEquals(Assert.java:542) at 
> org.apache.hadoop.hbase.master.TestDistributedLogSplitting.testLogReplayForDisablingTable(TestDistributedLogSplitting.java:838)
>  
> {code}
> This was due to the loop starting around line 823 not picking up any edits 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)