[
https://issues.apache.org/jira/browse/HBASE-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881288#comment-13881288
]
Andrew Purtell commented on HBASE-10408:
----------------------------------------
bq. This flag was removed by introducing label for outer loop.
Yep, labeled jumps aka "gotos" should be avoided unless necessary in my
opinion. I realize this is just test code but we are supposed to do code review
here after all. No need to point out existing occurrences of this idiom in our
code. I said "unless necessary". This is a bigger change than you needed to
make to fix the test.
> Intermittent TestDistributedLogSplitting#testLogReplayForDisablingTable
> failure
> -------------------------------------------------------------------------------
>
> Key: HBASE-10408
> URL: https://issues.apache.org/jira/browse/HBASE-10408
> Project: HBase
> Issue Type: Test
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 10408-v1.txt, 10408-v2.txt,
> TestDistributedLogSplitting.out,
> testDistributedLogSplitting-disablingTable.html
>
>
> Here was the assertion failure:
> {code} java.lang.AssertionError: expected:<1000> but was:<0> at
> org.junit.Assert.fail(Assert.java:88) at
> org.junit.Assert.failNotEquals(Assert.java:743) at
> org.junit.Assert.assertEquals(Assert.java:118) at
> org.junit.Assert.assertEquals(Assert.java:555) at
> org.junit.Assert.assertEquals(Assert.java:542) at
> org.apache.hadoop.hbase.master.TestDistributedLogSplitting.testLogReplayForDisablingTable(TestDistributedLogSplitting.java:838)
>
> {code}
> This was due to the loop starting around line 823 not picking up any edits
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
