[
https://issues.apache.org/jira/browse/HBASE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884451#comment-13884451
]
Hadoop QA commented on HBASE-10431:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12625606/HBASE-10431.v2.patch
against trunk revision .
ATTACHMENT ID: 12625606
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 18 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
setEventTypeCode(type.getCode()).setRegionName(HBasePrivateZeroCopyByteString.wrap(regionName)).
+ if (this.minColumn != null)
builder.setMinColumn(HBasePrivateZeroCopyByteString.wrap(this.minColumn));
+ if (this.maxColumn != null)
builder.setMaxColumn(HBasePrivateZeroCopyByteString.wrap(this.maxColumn));
+ if (this.stopRowKey != null)
builder.setStopRowKey(HBasePrivateZeroCopyByteString.wrap(this.stopRowKey));
+
cellBuilder.setValue(HBasePrivateZeroCopyByteString.wrap(Bytes.toBytes(META_SERVERNAME.getStartcode())));
+
builder.setFamily(HBasePrivateZeroCopyByteString.wrap(cell.getFamilyArray(),
cell.getFamilyOffset(),
+
builder.setValue(HBasePrivateZeroCopyByteString.wrap(cell.getValueArray(),
cell.getValueOffset(),
+ ByteString name =
HBasePrivateZeroCopyByteString.wrap(HRegionInfo.FIRST_META_REGIONINFO.getRegionName());
+
keyBuilder.setEncodedRegionName(HBasePrivateZeroCopyByteString.wrap(HConstants.EMPTY_BYTE_ARRAY));
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8540//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8540//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8540//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8540//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8540//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8540//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8540//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8540//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8540//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8540//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8540//console
This message is automatically generated.
> Rename com.google.protobuf.ZeroCopyLiteralByteString
> ----------------------------------------------------
>
> Key: HBASE-10431
> URL: https://issues.apache.org/jira/browse/HBASE-10431
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.96.1.1
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Fix For: 0.98.0, 0.96.2, 0.99.0
>
> Attachments: HBASE-10431.patch, HBASE-10431.v2.patch
>
>
> As we are hijacking the protobuf package, we should do our best to limit the
> probability to have a conflict on the class name.
> Today, we have the same class name as AsyncHBase, but our contains a method
> that AsyncHBase does not have.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
