[
https://issues.apache.org/jira/browse/HBASE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884724#comment-13884724
]
Nicolas Liochon commented on HBASE-10431:
-----------------------------------------
bq. +1 on the fix in general for trunk and 0.98 after the 1.0 compile problem
is fixed.
yes, even if git says it's a rename in the status, the diff does not include
the renamed files. The second patch worked.
Are the lines longer than 100 an issue? If yes I will fix on commit.
If not I will commit it. I think we should commit it on .96 as well. Any
opinion?
> Rename com.google.protobuf.ZeroCopyLiteralByteString
> ----------------------------------------------------
>
> Key: HBASE-10431
> URL: https://issues.apache.org/jira/browse/HBASE-10431
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.96.1.1
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Fix For: 0.98.0, 0.96.2, 0.99.0
>
> Attachments: HBASE-10431.patch, HBASE-10431.v2.patch
>
>
> As we are hijacking the protobuf package, we should do our best to limit the
> probability to have a conflict on the class name.
> Today, we have the same class name as AsyncHBase, but our contains a method
> that AsyncHBase does not have.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
