[ 
https://issues.apache.org/jira/browse/HBASE-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889882#comment-13889882
 ] 

Nick Dimiduk commented on HBASE-10455:
--------------------------------------

Is this the kind of thing we can catch with FindBugs?

> cleanup InterruptedException management
> ---------------------------------------
>
>                 Key: HBASE-10455
>                 URL: https://issues.apache.org/jira/browse/HBASE-10455
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, master, regionserver
>    Affects Versions: 0.98.0, 0.99.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: 10455.v1.patch
>
>
> 4 changes in this code:
> 1) When caught and rethrowed as a IOException we always rethrow 
> InterruptedIOException
> 2) When we were both throwing an exception AND resetting the interrupt status 
> we only throw an exception now.
> 3) When we were trying to reset the status by Thread.interrupted() (which 
> does not do that), we now do it for real with a 
> Thread.currentThread.interrupt().
> 4) Sometimes, we were rethrowing something else then InterruptedIOException, 
> while the contract would have allowed it. I've changed this as well.
> This patch does not make means that we're fine when we're interrupted, but 
> we're globally cleaner at least. I will then create other patches specific to 
> some parts.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to