[
https://issues.apache.org/jira/browse/HBASE-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890528#comment-13890528
]
Nicolas Liochon commented on HBASE-10455:
-----------------------------------------
bq. TestZKSecretWatcher may need fixing after this, if the precommit failure is
not spurious
I've ran the test 30 times locally, it works.
bq. Is this the kind of thing we can catch with FindBugs?
I don't know how to configure FindBugs for this. It could be a specific rule
today. A long time ago, I've added some rules to PMD it was not difficult but
not trivial either (a few hours of work).
> cleanup InterruptedException management
> ---------------------------------------
>
> Key: HBASE-10455
> URL: https://issues.apache.org/jira/browse/HBASE-10455
> Project: HBase
> Issue Type: Bug
> Components: Client, master, regionserver
> Affects Versions: 0.98.0, 0.99.0
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Fix For: 0.98.0, 0.99.0
>
> Attachments: 10455.v1.patch
>
>
> 4 changes in this code:
> 1) When caught and rethrowed as a IOException we always rethrow
> InterruptedIOException
> 2) When we were both throwing an exception AND resetting the interrupt status
> we only throw an exception now.
> 3) When we were trying to reset the status by Thread.interrupted() (which
> does not do that), we now do it for real with a
> Thread.currentThread.interrupt().
> 4) Sometimes, we were rethrowing something else then InterruptedIOException,
> while the contract would have allowed it. I've changed this as well.
> This patch does not make means that we're fine when we're interrupted, but
> we're globally cleaner at least. I will then create other patches specific to
> some parts.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
