[ 
https://issues.apache.org/jira/browse/HBASE-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904652#comment-13904652
 ] 

Jean-Daniel Cryans commented on HBASE-8329:
-------------------------------------------

[~sershe] Looking back at my unread emails I found that I didn't reply to your 
latest request so here it is.

PeakCompactionsThrottle could use some more complete javadoc, also it might be 
good to note somewhere that we're limiting speed _per_ compaction, not RS-wide. 
Bumping up the number of concurrent compaction handlers won't make throttling 
more aggressive. Could be counter-intuitive for some folks.

Also this comment has an extra white space "Limit peak hour compaction speed , 
slow down when it is too fast."

Can be fixed on commit, +1.

> Limit compaction speed
> ----------------------
>
>                 Key: HBASE-8329
>                 URL: https://issues.apache.org/jira/browse/HBASE-8329
>             Project: HBase
>          Issue Type: Improvement
>          Components: Compaction
>            Reporter: binlijin
>            Assignee: Sergey Shelukhin
>             Fix For: 0.99.0
>
>         Attachments: HBASE-8329-2-trunk.patch, HBASE-8329-3-trunk.patch, 
> HBASE-8329-4-trunk.patch, HBASE-8329-5-trunk.patch, HBASE-8329-6-trunk.patch, 
> HBASE-8329-7-trunk.patch, HBASE-8329-8-trunk.patch, HBASE-8329-9-trunk.patch, 
> HBASE-8329-trunk.patch
>
>
> There is no speed or resource limit for compaction,I think we should add this 
> feature especially when request burst.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to