[ 
https://issues.apache.org/jira/browse/HBASE-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941232#comment-13941232
 ] 

Matteo Bertozzi commented on HBASE-8963:
----------------------------------------

{quote}I don't imagine anyone wanting to run with skip archive as a global 
config on production. I think we should not do the global config at all{quote}
What is the motivation? If you don't care about snapshots or other form of 
backup you can turn of the archiver

{quote}Doesn't snapshots refer to files in the archive? If we do SKIP_ARCHIVE 
as a table property, the previous snapshots will be broken with compactions I 
guess.{quote}
No, if you have skipArchive on.. we must check anyway if the file is referenced 
by someone. And is exactly what this patch is doing. so if you have skipArchive 
true but the file is referenced by a snapshot it will be archived anyway.

{quote}I think we should do a "rm -rf" kind of think in drop table. If the 
files are not referred, they are not moved to archive, but deleted 
instead.{quote}
I was thinking at the table flag also to avoid stuff like "echo 'drop_table', 
'skip_archive' | hbase shell" executed by mistake.
since in that case if you want to switch from a table with skip archive false 
to true you have to do an alter, which it will have 0 cost since the table is 
already disabled and it will be only a master side operation.

> Add configuration option to skip HFile archiving
> ------------------------------------------------
>
>                 Key: HBASE-8963
>                 URL: https://issues.apache.org/jira/browse/HBASE-8963
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: bharath v
>             Fix For: 0.99.0
>
>         Attachments: HBASE-8963.trunk.v1.patch, HBASE-8963.trunk.v2.patch, 
> HBASE-8963.trunk.v3.patch, HBASE-8963.trunk.v4.patch, 
> HBASE-8963.trunk.v5.patch, HBASE-8963.trunk.v6.patch, 
> HBASE-8963.trunk.v7.patch
>
>
> Currently HFileArchiver is always called when a table is dropped.
> A configuration option (either global or per table) should be provided so 
> that archiving can be skipped when table is deleted.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to