[
https://issues.apache.org/jira/browse/HBASE-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961326#comment-13961326
]
Hadoop QA commented on HBASE-8963:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12638896/HBASE-8963.trunk.v8.patch
against trunk revision .
ATTACHMENT ID: 12638896
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 11 new
or modified tests.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail.
{color:red}-1 findbugs{color}. The patch appears to cause Findbugs
(version 1.3.9) to fail.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public static void archiveRegion(Configuration conf, FileSystem fs,
HRegionInfo info, HTableDescriptor htd)
+ Path tableDir, byte[] family, Collection<StoreFile> compactedFiles,
HTableDescriptor htd) throws IOException {
+ private static List<File> resolveAndArchive(Configuration conf, FileSystem
fs, Path baseArchiveDir,
+ if(conf.getBoolean(HFILE_SKIP_ARCHIVE_CONF_KEY, true) || ((htd != null) &&
htd.isSkipArchiveEnabled())){
+ HFileArchiver.archiveRegion(this.services.getConfiguration(), fs,
regionA, getTableDescriptor(regionA.getTable()));
+ HFileArchiver.archiveRegion(this.services.getConfiguration(), fs,
regionB, getTableDescriptor(regionB.getTable()));
+ HFileArchiver.archiveRegion(this.services.getConfiguration(), fs,
parent, getTableDescriptor(parent.getTable()));
+ HFileArchiver.archiveRegion(conf, fs, region,
this.services.getTableDescriptors().get(region.getTable()));
+ public void removeStoreFile(final HTableDescriptor htd, final String
familyName, final Path filePath)
+ public void removeStoreFiles(final HTableDescriptor htd, final String
familyName, final Collection<StoreFile> storeFiles)
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9207//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9207//console
This message is automatically generated.
> Add configuration option to skip HFile archiving
> ------------------------------------------------
>
> Key: HBASE-8963
> URL: https://issues.apache.org/jira/browse/HBASE-8963
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: bharath v
> Fix For: 0.99.0
>
> Attachments: HBASE-8963.trunk.v1.patch, HBASE-8963.trunk.v2.patch,
> HBASE-8963.trunk.v3.patch, HBASE-8963.trunk.v4.patch,
> HBASE-8963.trunk.v5.patch, HBASE-8963.trunk.v6.patch,
> HBASE-8963.trunk.v7.patch, HBASE-8963.trunk.v8.patch
>
>
> Currently HFileArchiver is always called when a table is dropped.
> A configuration option (either global or per table) should be provided so
> that archiving can be skipped when table is deleted.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
