[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961146#comment-13961146
]
stack commented on HBASE-10915:
-------------------------------
Should this be a factory?
+ CloseRegionConsensus consensus = new
ZkCloseRegionConsensus(this.getZooKeeper());
How comes we are talking about zk here?
+ ZkCloseRegionConsensus.ZkCloseRegionDetails zkCrd =
+ new ZkCloseRegionConsensus.ZkCloseRegionDetails();
+ zkCrd.setZk(zk);
+ zkCrd.setExpectedVersion(versionOfClosingNode);
+ zkCrd.setServerName(this.getServerName());
Aren't we trying to put the implementation behind an interface yet we are all
about zk here? Should the CloseRegionConsensus take an 'info' object that it
just passes through to the implementation rather than do something like this:
+ crh = new CloseMetaHandler(this, this, hri, abort, consensus, zkCrd);
...where we pass the consensus and the info the consensus needs to run: i.e.
zkCrd?
Thanks.
> Decouple CloseRegionHandler from ZooKeeper
> ------------------------------------------
>
> Key: HBASE-10915
> URL: https://issues.apache.org/jira/browse/HBASE-10915
> Project: HBase
> Issue Type: Sub-task
> Components: Zookeeper
> Reporter: Mikhail Antonov
> Assignee: Mikhail Antonov
> Attachments: HBASE-10915.patch
>
>
> Decouple CloseRegionHandler class from ZK API.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
