[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961360#comment-13961360
]
Mikhail Antonov commented on HBASE-10915:
-----------------------------------------
Thanks for review!
- regarding how to instantiate consensus implementation, yep, I didn't yet
make that separation, will add in next version of patch (or in separate jira).
I guess we would have a property like hbase.consensus.provider in
hbase-site.xml, and for now the only acceptable value would be ZOOKEEPER, and
once we hook up other consensus implementations, we'll add them?
- on passing zkcrd or similar object to the factory rather than passing it to
the handler itself, it will work for all cases where handler doesn't need to
pass any additional information to consensus class (which seems to be correct
for this handler, not yet sure about others handlers left, like
OpenRegionHandler). In case additional info needs to be pass, we can have
interface (like the one CloseRegionDetails and implementing class
ZkCloseRegionDetails) which allows to pass the details independent from the
consensus implementation.
Original idea as to why pass around this object is that in ZK version of
consensus, the flow in case of handlers is that we:
- create handler, play with some znodes, remember expectedVersion
- submit handler to executors service, wait for it to run
- as handler executes, it plays more with znodes, and here we check for znode
versions, so consensus needs to remember this version to compare against.
> Decouple CloseRegionHandler from ZooKeeper
> ------------------------------------------
>
> Key: HBASE-10915
> URL: https://issues.apache.org/jira/browse/HBASE-10915
> Project: HBase
> Issue Type: Sub-task
> Components: Zookeeper
> Reporter: Mikhail Antonov
> Assignee: Mikhail Antonov
> Attachments: HBASE-10915.patch
>
>
> Decouple CloseRegionHandler class from ZK API.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
