[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963759#comment-13963759
]
Ted Yu commented on HBASE-10915:
--------------------------------
{code}
+public class ConsensusFactory {
{code}
Would ConsensusProviderFactory be a better name ?
{code}
+public class ZkConsensusProvider implements ConsensusProvider {
{code}
Add annotation for class audience and stability.
{code}
+ } catch (KeeperException e) {
+ e.printStackTrace();
{code}
Change the above to LOG.error().
{code}
+ * regionserver side internally (not because of PRC call from master).
+ */
+ CloseRegionDetails getDetailsForCloseIgnoringDetails();
{code}
Typo: PRC -> RPC
I am confused by the method name - if we're getting details, why do we ignore
details ?
> Decouple region closing from ZooKeeper
> --------------------------------------
>
> Key: HBASE-10915
> URL: https://issues.apache.org/jira/browse/HBASE-10915
> Project: HBase
> Issue Type: Sub-task
> Components: Zookeeper
> Reporter: Mikhail Antonov
> Assignee: Mikhail Antonov
> Attachments: HBASE-10915.patch, HBASE-10915.patch
>
>
> Decouple CloseRegionHandler class and code using it (HRegionServer,
> ProtobufUtil) from ZK API.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
