[
https://issues.apache.org/jira/browse/HBASE-10801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963896#comment-13963896
]
Matt Corgan commented on HBASE-10801:
-------------------------------------
it's great ram. i wish i could help.
{quote}+ protected static class SeekerState implements Cell, Comparable<Cell>
{{quote}
I noticed you added Comparable<Cell> between patches 1 and 2. I know I had
Comparable<Cell> in that example code, but like your first patch, I was now
thinking it's unnecessary since Cell extends Comparable<Cell> already. Did you
find a reason for it?
It's been a long time so I can't remember, but I had also tried another
strategy for copying all the individual fields around.
{code}
+ rowLength = nextState.rowLength;
+ familyOffset = nextState.familyOffset;
+ familyLength = nextState.familyLength;
+ qualifierOffset = nextState.qualifierOffset;
+ qualifierLength = nextState.qualifierLength;
+ timestamp = nextState.timestamp;
+ typeByte = nextState.typeByte;
{code}
I wish i could remember - it might have been keeping a "currentState" struct
and doing the above with "currentState = nextState" to avoid the 7 individual
copies. I only mention it because it was a noticeable improvement, like 20%.
I wouldn't hold up this patch for it, but something to think on.
> Ensure DBE interfaces can work with Cell
> ----------------------------------------
>
> Key: HBASE-10801
> URL: https://issues.apache.org/jira/browse/HBASE-10801
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10801.patch, HBASE-10801_1.patch
>
>
> Some changes to the interfaces may be needed for DBEs or may be the way it
> works currently may be need to be modified inorder to make DBEs work with
> Cells. Suggestions and ideas welcome.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
