[
https://issues.apache.org/jira/browse/HBASE-10801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964045#comment-13964045
]
ramkrishna.s.vasudevan commented on HBASE-10801:
------------------------------------------------
[~mcorgan]
I found one issue when I tried to merge this patch with HBASE-7319. I tried to
return a shallow copy of the seeker state to the upper layers.
But things would break when
{code}
public Cell next() throws IOException {
Cell retKey = cur;
try {
// only seek if we aren't at the end. cur == null implies 'end'.
if (cur != null) {
hfs.next();
cur = hfs.getKeyValue();
if (hasMVCCInfo)
skipKVsNewerThanReadpoint();
}
} catch(IOException e) {
throw new IOException("Could not iterate " + this, e);
}
return retKey;
}
{code}
in StorefileScanner. Only if we do a deepClone we could get away with this.
Because the reference of retKey is always pointing to the 'cur' represented by
'SeekerState'.
A shallow copy would also point to the same keyBuffer only. Am I missing
something?
> Ensure DBE interfaces can work with Cell
> ----------------------------------------
>
> Key: HBASE-10801
> URL: https://issues.apache.org/jira/browse/HBASE-10801
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10801.patch, HBASE-10801_1.patch
>
>
> Some changes to the interfaces may be needed for DBEs or may be the way it
> works currently may be need to be modified inorder to make DBEs work with
> Cells. Suggestions and ideas welcome.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
