[
https://issues.apache.org/jira/browse/HBASE-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969801#comment-13969801
]
Hadoop QA commented on HBASE-10985:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12640297/HBASE-10985.patch
against trunk revision .
ATTACHMENT ID: 12640297
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 6
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ if
(ConsensusProviderFactory.getConsensusProvider(server.getConfiguration()).getSplitTransactionConsensus().transitionSplittingNode(watcher,
p,
+ znodeVersion =
consensus.getSplitTransactionConsensus().getZKNode(server, services, parent,
hri_a, hri_b);
+ consensus.getSplitTransactionConsensus().transitionNode(server, services,
regions.getFirst(), regions.getSecond(),znodeVersion, parent);
+ * @see
org.apache.hadoop.hbase.regionserver.consensus.SplitTransactionConsensus#createNodeSplitting(org.apache.hadoop.hbase.Server,
org.apache.hadoop.hbase.regionserver.HRegion,
org.apache.hadoop.hbase.ServerName, org.apache.hadoop.hbase.HRegionInfo,
org.apache.hadoop.hbase.HRegionInfo)
+ * @see
org.apache.hadoop.hbase.regionserver.consensus.SplitTransactionConsensus#transitionSplittingNode(org.apache.hadoop.hbase.Server,
org.apache.hadoop.hbase.HRegionInfo, org.apache.hadoop.hbase.HRegionInfo,
org.apache.hadoop.hbase.HRegionInfo, org.apache.hadoop.hbase.ServerName, int,
org.apache.hadoop.hbase.executor.EventType,
org.apache.hadoop.hbase.executor.EventType)
+ * @see
org.apache.hadoop.hbase.regionserver.consensus.SplitTransactionConsensus#transitionSplittingNode(org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher,
org.apache.hadoop.hbase.HRegionInfo, org.apache.hadoop.hbase.HRegionInfo,
org.apache.hadoop.hbase.HRegionInfo, org.apache.hadoop.hbase.ServerName, int,
org.apache.hadoop.hbase.executor.EventType,
org.apache.hadoop.hbase.executor.EventType)
+ * @see
org.apache.hadoop.hbase.regionserver.consensus.SplitTransactionConsensus#getZKNode(org.apache.hadoop.hbase.Server,
org.apache.hadoop.hbase.regionserver.RegionServerServices,
org.apache.hadoop.hbase.regionserver.HRegion,
org.apache.hadoop.hbase.HRegionInfo, org.apache.hadoop.hbase.HRegionInfo)
+ * @see
org.apache.hadoop.hbase.regionserver.consensus.SplitTransactionConsensus#transitionNode(org.apache.hadoop.hbase.Server,
org.apache.hadoop.hbase.regionserver.RegionServerServices,
org.apache.hadoop.hbase.regionserver.HRegion,
org.apache.hadoop.hbase.regionserver.HRegion, int,
org.apache.hadoop.hbase.regionserver.HRegion)
+ * @see
org.apache.hadoop.hbase.regionserver.consensus.SplitTransactionConsensus#cleanZK(org.apache.hadoop.hbase.Server,
org.apache.hadoop.hbase.HRegionInfo)
+ void transitionNode(Server server, RegionServerServices services, HRegion
a, HRegion b,int znodeVersion, HRegion parent)
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitTransaction
org.apache.hadoop.hbase.coprocessor.TestCoprocessorInterface
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9293//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9293//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9293//console
This message is automatically generated.
> Decouple Split Transaction from Zookeeper
> -----------------------------------------
>
> Key: HBASE-10985
> URL: https://issues.apache.org/jira/browse/HBASE-10985
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Zookeeper
> Reporter: Sergey Soldatov
> Attachments: HBASE-10985.patch
>
>
> As part of HBASE-10296 SplitTransaction should be decoupled from Zookeeper.
> This is an initial patch for review. At the moment the consensus provider
> placed directly to SplitTransaction to minimize affected code. In the ideal
> world it should be done in HServer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
