[ 
https://issues.apache.org/jira/browse/HBASE-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976678#comment-13976678
 ] 

Hadoop QA commented on HBASE-10985:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12641214/HBASE-10985.patch
  against trunk revision .
  ATTACHMENT ID: 12641214

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new 
or modified tests.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 6 
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the trunk's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +        if 
(ConsensusProviderFactory.getConsensusProvider(server.getConfiguration()).getSplitTransactionConsensus().transitionSplittingNode(watcher,
 p,
+      znodeVersion = 
consensus.getSplitTransactionConsensus().getZKNode(server, services, parent, 
hri_a, hri_b);
+    consensus.getSplitTransactionConsensus().transitionNode(server, services, 
regions.getFirst(), regions.getSecond(),znodeVersion, parent);
+   * @see 
org.apache.hadoop.hbase.regionserver.consensus.SplitTransactionConsensus#transitionSplittingNode(org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher,
 org.apache.hadoop.hbase.HRegionInfo, org.apache.hadoop.hbase.HRegionInfo, 
org.apache.hadoop.hbase.HRegionInfo, org.apache.hadoop.hbase.ServerName, int, 
org.apache.hadoop.hbase.executor.EventType, 
org.apache.hadoop.hbase.executor.EventType)
+    void transitionNode(Server server, RegionServerServices services, HRegion 
a, HRegion b,int znodeVersion, HRegion parent)

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence
                  org.apache.hadoop.hbase.regionserver.TestHRegion
                  org.apache.hadoop.hbase.client.TestAdmin
                  org.apache.hadoop.hbase.regionserver.TestHRegionBusyWait
                  org.apache.hadoop.hbase.master.TestTableLockManager
                  org.apache.hadoop.hbase.client.TestFromClientSide
                  org.apache.hadoop.hbase.rest.TestTableResource
                  
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
                  
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
                  
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
                  org.apache.hadoop.hbase.util.TestHBaseFsck

     {color:red}-1 core zombie tests{color}.  There are 3 zombie test(s):       
at 
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery.testSplitWhileBulkLoadPhase(TestLoadIncrementalHFilesSplitRecovery.java:361)
        at 
org.apache.hadoop.hbase.master.TestMaster.testMasterOpsWhileSplitting(TestMaster.java:89)
        at 
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery.testSplitWhileBulkLoadPhase(TestLoadIncrementalHFilesSplitRecovery.java:361)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9358//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9358//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9358//console

This message is automatically generated.

> Decouple Split Transaction from Zookeeper
> -----------------------------------------
>
>                 Key: HBASE-10985
>                 URL: https://issues.apache.org/jira/browse/HBASE-10985
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Zookeeper
>            Reporter: Sergey Soldatov
>         Attachments: HBASE-10985.patch, HBASE-10985.patch
>
>
> As part of  HBASE-10296 SplitTransaction should be decoupled from Zookeeper. 
> This is an initial patch for review. At the moment the consensus provider  
> placed directly to SplitTransaction to minimize affected code. In the ideal 
> world it should be done in HServer.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to