[
https://issues.apache.org/jira/browse/HBASE-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972022#comment-13972022
]
Ted Yu commented on HBASE-10950:
--------------------------------
{code}
+ public static final int DEFAULT_VERSIONS =
HBaseConfiguration.create().getInt(
+ "hbase.column.MaxVersion", 1);
{code}
There is no need to use mixed cases in config parameter name. How about naming
this 'hbase.column.max.version' ?
For TestColumnDescriptorDefaultVersion.java, I think the file should be named
TestColumnDescriptorDefaultVersions.java since we allow the user to set default
versions value.
{code}
+ * Copyright The Apache Software Foundation Licensed to the Apache Software
Foundation (ASF) under
{code}
Please copy copyright from existing file - the format is off.
{code}
+ * Verify that the HTableDescriptor is updated after addColumn(),
deleteColumn() and modifyTable()
{code}
The above javadoc (HTableDescriptor) doesn't seem to align with the class name.
I ran the new test:
{code}
Running
org.apache.hadoop.hbase.master.handler.TestColumnDescriptorDefaultVersion
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.096 sec
{code}
It should be medium test.
> Add a configuration point for MaxVersion of Column Family
> ----------------------------------------------------------
>
> Key: HBASE-10950
> URL: https://issues.apache.org/jira/browse/HBASE-10950
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Affects Versions: 0.98.0, 0.96.0
> Reporter: Demai Ni
> Assignee: Enoch Hsu
> Fix For: 0.99.0, 0.98.2, 0.96.3
>
> Attachments: HBASE_10950.patch
>
>
> Starting on 0.96.0. HColumnDescriptor.DEFAULT_VERSIONS change to 1 from 3.
> So a columnfamily will be default have 1 version of data. Currently a user
> can specifiy the maxVersion during create table time or alter the columnfam
> later. This feature will add a configuration point in hbase-sit.xml so that
> an admin can set the default globally.
> a small discussion in
> [HBASE-10941|https://issues.apache.org/jira/browse/HBASE-10941] lead to this
> jira
--
This message was sent by Atlassian JIRA
(v6.2#6252)
