[ 
https://issues.apache.org/jira/browse/HBASE-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973200#comment-13973200
 ] 

Nick Dimiduk commented on HBASE-10950:
--------------------------------------

This isn't quite right.

{noformat}
-  public static final int DEFAULT_VERSIONS = 1;
+  public static final int DEFAULT_VERSIONS = 
HBaseConfiguration.create().getInt(
+    "hbase.column.max.version", 1);
{noformat}

DEFAULT_VERSIONS shouldn't change. Instead, you should change the places it's 
referenced to retrieve the site-configured default value first, and then fall 
back to the column descriptor.

Also, creating a config inplace like this is goofy. It means people won't have 
a chance to add customizations to their conf object before it's parsed. Better 
to use the appropriate conf object for the context.

> Add  a configuration point for MaxVersion of Column Family
> ----------------------------------------------------------
>
>                 Key: HBASE-10950
>                 URL: https://issues.apache.org/jira/browse/HBASE-10950
>             Project: HBase
>          Issue Type: Improvement
>          Components: Admin
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Demai Ni
>            Assignee: Enoch Hsu
>             Fix For: 0.99.0, 0.98.2, 0.96.3
>
>         Attachments: HBASE_10950.patch, HBASE_10950_v2.patch
>
>
> Starting on 0.96.0.  HColumnDescriptor.DEFAULT_VERSIONS change to 1 from 3. 
> So a columnfamily will be default have 1 version of data. Currently a user 
> can specifiy the maxVersion during create table time or alter the columnfam 
> later. This feature will add a configuration point in hbase-sit.xml so that 
> an admin can set the default globally. 
> a small discussion in 
> [HBASE-10941|https://issues.apache.org/jira/browse/HBASE-10941] lead to this 
> jira



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to