[ 
https://issues.apache.org/jira/browse/HBASE-11001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973824#comment-13973824
 ] 

ramkrishna.s.vasudevan commented on HBASE-11001:
------------------------------------------------

Should we check for args[1] also here
{code}
if args[0].nil? or args[0].kind_of?(String)
{code}
because below we expect args[1] to be qualifier.
I would suggest make the *args to args = {} and for the case of 'grant' just do 
args[FAMILY], args[QUALIFIER].  So that the args are always of type Hash.  So 
need not check with 'arg[i].'



> Shell support for granting cell permissions for testing
> -------------------------------------------------------
>
>                 Key: HBASE-11001
>                 URL: https://issues.apache.org/jira/browse/HBASE-11001
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Minor
>             Fix For: 0.99.0, 0.98.2
>
>         Attachments: 11001.patch
>
>
> For testing purposes it would be useful if the shell can support a simple 
> syntax for adding cell ACLs to existing cells. Consider a combination of 
> current 'grant' and 'scan' commands. 
> {noformat}
> grant '<userOrGroup>', '<perms>', '[<ns>:]<table>', { ... }
> {noformat}
> where the last argument is a scanner specification, for example (borrowed 
> from scan.rb): \\
> - { COLUMNS => 'c1', STARTROW => 'abc', ENDROW => 'xyz' }
> - { COLUMNS => 'c1', TIMERANGE => [123, 456] }
> - { COLUMNS => ['c1', 'c2'], FILTER => "(PrefixFilter ('foo') AND
>     (QualifierFilter (=, 'bar:'))) AND (TimestampsFilter (123, 456))" }



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to