[
https://issues.apache.org/jira/browse/HBASE-11001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976352#comment-13976352
]
Hadoop QA commented on HBASE-11001:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12641166/HBASE-11001.patch
against trunk revision .
ATTACHMENT ID: 12641166
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ raise ArgumentError, "Arguments should be a hash. Failed to parse
#{args.inspect}, #{args.class}"
+ raise(ArgumentError, "Authorizations must be a Array type") unless
authorizations.kind_of?(Array)
+ raise(ArgumentError, "Permissions are not of String type") unless
permissions.kind_of?(String)
+ raise(ArgumentError, "Table name is not of String type") unless
table_name.kind_of?(String)
+ raise(ArgumentError, "Qualifier is not of String type") unless
qualifier.kind_of?(String)
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9356//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9356//console
This message is automatically generated.
> Shell support for granting cell permissions for testing
> -------------------------------------------------------
>
> Key: HBASE-11001
> URL: https://issues.apache.org/jira/browse/HBASE-11001
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Priority: Minor
> Fix For: 0.99.0, 0.98.2
>
> Attachments: 11001.patch, HBASE-11001.patch
>
>
> For testing purposes it would be useful if the shell can support a simple
> syntax for adding cell ACLs to existing cells. Consider a combination of
> current 'grant' and 'scan' commands.
> {noformat}
> grant <table>, <permissions>, <scan>
> {noformat}
> where <table> is a string, a table name, optionally prefixed with a namespace
> where <permissions> is a Hash type that maps permissions to users, for
> example: \\
> - { "user1" => "RW", "user2" => "R", "@group1" => "R" }
> where <scan> is a Hash type containing a scanner specification, for example
> (borrowed from scan.rb): \\
> - { COLUMNS => 'c1', STARTROW => 'abc', ENDROW => 'xyz' }
> - { COLUMNS => 'c1', TIMERANGE => [123, 456] }
> - { COLUMNS => ['c1', 'c2'], FILTER => "(PrefixFilter ('foo') AND
> (QualifierFilter (=, 'bar:'))) AND (TimestampsFilter (123, 456))" }
--
This message was sent by Atlassian JIRA
(v6.2#6252)
