[
https://issues.apache.org/jira/browse/HBASE-11092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986407#comment-13986407
]
stack commented on HBASE-11092:
-------------------------------
Server is top level Interface. I think ConsensusProvider is looking like it
should be w/ implemenations and supporting Interfaces down in the consensus
package? Then Server doesn't have to reach down into the consensus package.
Factory should be top level too?
Otherwise patch lgtm.
> Server interface should have method getConsensusProvider()
> ----------------------------------------------------------
>
> Key: HBASE-11092
> URL: https://issues.apache.org/jira/browse/HBASE-11092
> Project: HBase
> Issue Type: Sub-task
> Components: Consensus
> Affects Versions: 0.99.0
> Reporter: Mikhail Antonov
> Assignee: Mikhail Antonov
> Fix For: 0.99.0
>
> Attachments: HBASE-11092.diff, HBASE-11092.patch
>
>
> As discussed in comments to HBASE-10915, we need to have a proper way to
> retrieve instance of consensus provider, and Server interface seems the right
> one.
> Since Server interface lives in hbase-client maven module, the following
> approach is implemented in this patch:
> - hbase-client module has very basic (almost marker) interface
> ConsensusProvider to return instance of consensus provider from the Server
> - hbase-server module has BaseConsensusProvider which defines the consensus
> interfaces
> - Implementations shall subclass BaseConsensusProvider
> - whoever wants to get ConsensusProvider from raw Server interface on
> hbase-server side, has to typecast: (BaseConsensusProvider)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
