[ 
https://issues.apache.org/jira/browse/HBASE-11092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987080#comment-13987080
 ] 

stack commented on HBASE-11092:
-------------------------------

Is the patch right [~mantonov]?  It looks like you are doing as I suggest:

{code}
-import org.apache.hadoop.hbase.consensus.ConsensusProvider;
-import org.apache.hadoop.hbase.consensus.ConsensusProviderFactory;
+import org.apache.hadoop.hbase.ConsensusProvider;
+import org.apache.hadoop.hbase.ConsensusProviderFactory;
{code}

... but patch seems to have CP still in the consensus package?

> Server interface should have method getConsensusProvider()
> ----------------------------------------------------------
>
>                 Key: HBASE-11092
>                 URL: https://issues.apache.org/jira/browse/HBASE-11092
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Consensus
>    Affects Versions: 0.99.0
>            Reporter: Mikhail Antonov
>            Assignee: Mikhail Antonov
>             Fix For: 0.99.0
>
>         Attachments: HBASE-11092.patch, HBASE-11092.patch
>
>
> As discussed in comments to HBASE-10915, we need to have a proper way to 
> retrieve instance of consensus provider, and Server interface seems the right 
> one.
> Since Server interface lives in hbase-client maven module, the following 
> approach is implemented in this patch:
>  - hbase-client module has very basic (almost marker) interface 
> ConsensusProvider to return instance of consensus provider from the Server
>  - hbase-server module has BaseConsensusProvider which defines the consensus 
> interfaces
>  - Implementations shall subclass BaseConsensusProvider
>  - whoever wants to get ConsensusProvider from raw Server interface on 
> hbase-server side, has to typecast: (BaseConsensusProvider) 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to