[
https://issues.apache.org/jira/browse/HBASE-11051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986984#comment-13986984
]
Ted Yu commented on HBASE-11051:
--------------------------------
+ checkCompilationErrors $PATCH_DIR/patchJavadocWarnings.txt
Compilation error check is applied on javadoc output because
checkJavadocWarnings is called first ? That should be fine.
You can remove some dead code following the second call to
checkCompilationErrors.
{code}
if [[ $? != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail."
return 1
fi
{code}
Thanks
> checkJavacWarnings in test-patch.sh should bail out early if there is
> compilation error
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-11051
> URL: https://issues.apache.org/jira/browse/HBASE-11051
> Project: HBase
> Issue Type: Test
> Reporter: Ted Yu
> Assignee: Gustavo Anatoly
> Priority: Minor
> Attachments: HBASE-11051-v1.patch, HBASE-11051-v2.patch,
> HBASE-11051.patch, output.txt
>
>
> Currently checkJavacWarnings doesn't exit QA script in the presence of
> compilation error.
> Here is one example:
> https://builds.apache.org/job/PreCommit-HBASE-Build/9360/console .
> checkJavacWarnings should do the following so that it is clear what caused
> the QA run to fail:
> {code}
> if [[ $? != 0 ]] ; then
> ERR=`$GREP -A 5 'Compilation failure' $PATCH_DIR/trunkJavacWarnings.txt`
> echo "Trunk compilation is broken?
> \{code\}$ERR\{code\}"
> cleanupAndExit 1
> fi
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
