[
https://issues.apache.org/jira/browse/HBASE-11051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987234#comment-13987234
]
Hadoop QA commented on HBASE-11051:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12642923/output-v1.txt
against trunk revision .
ATTACHMENT ID: 12642923
{color:red}-1 @author{color}. The patch appears to contain 2 @author tags
which the Hadoop community has agreed to not allow in code contributions.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9440//console
This message is automatically generated.
> checkJavacWarnings in test-patch.sh should bail out early if there is
> compilation error
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-11051
> URL: https://issues.apache.org/jira/browse/HBASE-11051
> Project: HBase
> Issue Type: Test
> Reporter: Ted Yu
> Assignee: Gustavo Anatoly
> Priority: Minor
> Attachments: HBASE-11051-v1.patch, HBASE-11051-v2.patch,
> HBASE-11051-v3.patch, HBASE-11051-v4.patch, HBASE-11051.patch, output-v1.txt,
> output.txt
>
>
> Currently checkJavacWarnings doesn't exit QA script in the presence of
> compilation error.
> Here is one example:
> https://builds.apache.org/job/PreCommit-HBASE-Build/9360/console .
> checkJavacWarnings should do the following so that it is clear what caused
> the QA run to fail:
> {code}
> if [[ $? != 0 ]] ; then
> ERR=`$GREP -A 5 'Compilation failure' $PATCH_DIR/trunkJavacWarnings.txt`
> echo "Trunk compilation is broken?
> \{code\}$ERR\{code\}"
> cleanupAndExit 1
> fi
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
