[ 
https://issues.apache.org/jira/browse/HBASE-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001549#comment-14001549
 ] 

Nick Dimiduk commented on HBASE-11104:
--------------------------------------

I see no mentions of ImportTsv in the findbugs output over hbase-server and 
findbugs isn't run over hbase-it.

Your truck patch looks good to me. Is this new config in ImportTsv picked up 
automatically when run on a secure cluster? It's user-facing, right? Can you 
add some docstrings and update the help message regarding how to pass in the 
credentials file? Maybe s/credentials/importtsv.credentials/. Thanks.

> IntegrationTestImportTsv#testRunFromOutputCommitter misses credential 
> initialization
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-11104
>                 URL: https://issues.apache.org/jira/browse/HBASE-11104
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Vandana Ayyalasomayajula
>            Priority: Minor
>         Attachments: 11104-v1.txt, HBASE-11104_98_v3.patch, 
> HBASE-11104_trunk.patch, HBASE-11104_trunk.patch
>
>
> IntegrationTestImportTsv#testRunFromOutputCommitter a parent job that ships 
> the HBase dependencies.
> However, call to TableMapReduceUtil.initCredentials(job) is missing - making 
> this test fail on a secure cluster.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to