[jira] [Commented] (HBASE-11219) HRegionServer#createRegionLoad() should reuse RegionLoad.Builder instance when called in a loop

[Mikhail Antonov (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-11219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004303#comment-14004303
 ] 

Mikhail Antonov commented on HBASE-11219:
-----------------------------------------

{code}
if (regionLoadBldr == null) {
      regionLoadBldr = RegionLoad.newBuilder();
    }
{code}
May be instead this null check just create builder always on caller side (2 
places) in pass it in, rather than assign method param if null?

> HRegionServer#createRegionLoad() should reuse RegionLoad.Builder instance 
> when called in a loop
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11219
>                 URL: https://issues.apache.org/jira/browse/HBASE-11219
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 11219-v1.txt
>
>
> As Andrew showed in the attachment to HBASE-11165, 
> ClusterStatusProtos$RegionLoad$Builder took 25MB heap space.
> buildServerLoad() calls createRegionLoad() for each region on the region 
> server.
> One instance of ClusterStatusProtos$RegionLoad$Builder can be created outside 
> the loop and passed to createRegionLoad().
> Thanks Andrew for the finding.



--
This message was sent by Atlassian JIRA
(v6.2#6252)