[ 
https://issues.apache.org/jira/browse/HBASE-11219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004888#comment-14004888
 ] 

Andrew Purtell commented on HBASE-11219:
----------------------------------------

Patch v2 looks good. Can you quantify the impact?

> HRegionServer#createRegionLoad() should reuse RegionLoad.Builder instance 
> when called in a loop
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11219
>                 URL: https://issues.apache.org/jira/browse/HBASE-11219
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.99.0, 0.98.3
>
>         Attachments: 11219-v1.txt, 11219-v2.txt
>
>
> As Andrew showed in the attachment to HBASE-11165, 
> ClusterStatusProtos$RegionLoad$Builder took 25MB heap space.
> buildServerLoad() calls createRegionLoad() for each region on the region 
> server.
> One instance of ClusterStatusProtos$RegionLoad$Builder can be created outside 
> the loop and passed to createRegionLoad().
> Thanks Andrew for the finding.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to