[
https://issues.apache.org/jira/browse/HBASE-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008228#comment-14008228
]
stack commented on HBASE-11210:
-------------------------------
What is going on here? It is a Lars idea from two years ago but you, not Lars,
files an issue now Ted? The reason you give for why 'we' need this -- 'This
gives users / developers clear suggestion that custom filters should override
FilterBase instead of implementing Filter directly' -- is not a justification.
An Interface won't do this. Anoop may 'acknowledge' this 'idea' but since it
was 'offline', so we have no notion of whether he thought it a good idea or a
bad idea.
> Consider restoring Filter class back to an interface
> ----------------------------------------------------
>
> Key: HBASE-11210
> URL: https://issues.apache.org/jira/browse/HBASE-11210
> Project: HBase
> Issue Type: Task
> Reporter: Ted Yu
>
> In 0.94, Filter class is an interface.
> From Filter.java in 0.96 :
> {code}
> * Interface for row and column filters directly applied within the
> regionserver.
> ...
> * When implementing your own filters, consider inheriting {@link FilterBase}
> to help
> * you reduce boilerplate.
> {code}
> We should consider restoring Filter class back to an interface.
> Lars first brought up this notion:
> https://issues.apache.org/jira/browse/HBASE-6657?focusedCommentId=13456317&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13456317
> This gives users / developers clear suggestion that custom filters should
> override FilterBase instead of implementing Filter directly.
> Thanks to Anoop who acknowledged this idea during offline discussion.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
