[
https://issues.apache.org/jira/browse/HBASE-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008229#comment-14008229
]
Ted Yu commented on HBASE-11210:
--------------------------------
I am expecting [~lhofhansl] to comment on this issue.
bq. whether he thought it a good idea or a bad idea.
My interpretation is that Anoop thought of this idea positively.
Below was from Anoop when he and I discussed HBASE-10965 :
{code}
So making below changes we can do auto detect.
1. Change Filter to interface
2. Have abstract FilterBase and allow users to only extenf this. No direct impl
of Filter
3. Remove the hasFilterRow () api and do only the auto detect.
Reading correctly?
Sounds good to me then.
{code}
> Consider restoring Filter class back to an interface
> ----------------------------------------------------
>
> Key: HBASE-11210
> URL: https://issues.apache.org/jira/browse/HBASE-11210
> Project: HBase
> Issue Type: Task
> Reporter: Ted Yu
>
> In 0.94, Filter class is an interface.
> From Filter.java in 0.96 :
> {code}
> * Interface for row and column filters directly applied within the
> regionserver.
> ...
> * When implementing your own filters, consider inheriting {@link FilterBase}
> to help
> * you reduce boilerplate.
> {code}
> We should consider restoring Filter class back to an interface.
> Lars first brought up this notion:
> https://issues.apache.org/jira/browse/HBASE-6657?focusedCommentId=13456317&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13456317
> This gives users / developers clear suggestion that custom filters should
> override FilterBase instead of implementing Filter directly.
> Thanks to Anoop who acknowledged this idea during offline discussion.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
