[ 
https://issues.apache.org/jira/browse/HBASE-10935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010897#comment-14010897
 ] 

Matteo Bertozzi commented on HBASE-10935:
-----------------------------------------

[~tychang] yeah, I don't like much the client method with "String flushType" I 
think that the app should do the parsing and translate it in the 
SnapshotDescription.Type enum.

so to me the only remaining fixes for this patch are:
 * remove the "void snapshot(final byte[] snapshotName, final byte[] tableName, 
final String flushType)" method
 * interprete the type from the shell and call snapshot(..., 
SnapshotDescription.Type type) from the shell instead of the (..., String 
flushType)

> support snapshot policy where flush memstore can be skipped to prevent 
> production cluster freeze
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10935
>                 URL: https://issues.apache.org/jira/browse/HBASE-10935
>             Project: HBase
>          Issue Type: New Feature
>          Components: shell, snapshots
>    Affects Versions: 0.94.7, 0.94.18
>            Reporter: Tianying Chang
>            Assignee: Tianying Chang
>            Priority: Minor
>             Fix For: 0.99.0
>
>         Attachments: jira-10935-trunk.patch, jira-10935.patch
>
>
> We are using snapshot feature to do HBase disaster recovery. We will do 
> snapshot in our production cluster periodically. The current flush snapshot 
> policy require all regions of the table to coordinate to prevent write and do 
> flush at the same time. Since we use WALPlayer to complete the data that is 
> not in the snapshot HFile, we don't need the snapshot to do coordinated 
> flush. The snapshot just recored all the HFile that are already there. 
> I added the parameter in the HBase shell. So people can choose to use the 
> NoFlush snapshot when they need, like below. Otherwise, the default flush 
> snpahot support is not impacted. 
> >snaphot 'TestTable', 'TestSnapshot', 'skipFlush'



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to