[
https://issues.apache.org/jira/browse/HBASE-10935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012251#comment-14012251
]
Matteo Bertozzi commented on HBASE-10935:
-----------------------------------------
looks good to me.
only one question, do we need an else if {SKIP_FLUSH => false} or args it will
be empty in that case because it is equal the default value?
{code}
+ args.each do |arg|
+ if arg[SKIP_FLUSH] = 'true'
+ @admin.snapshot(snapshot_name.to_java_bytes,
table.to_java_bytes, SnapshotDescription::Type::SKIPFLUSH)
+ end
+ end
{code}
> support snapshot policy where flush memstore can be skipped to prevent
> production cluster freeze
> ------------------------------------------------------------------------------------------------
>
> Key: HBASE-10935
> URL: https://issues.apache.org/jira/browse/HBASE-10935
> Project: HBase
> Issue Type: New Feature
> Components: shell, snapshots
> Affects Versions: 0.94.7, 0.94.18
> Reporter: Tianying Chang
> Assignee: Tianying Chang
> Priority: Minor
> Fix For: 0.99.0
>
> Attachments: hbase-10935.txt, jira-10935-trunk.patch
>
>
> We are using snapshot feature to do HBase disaster recovery. We will do
> snapshot in our production cluster periodically. The current flush snapshot
> policy require all regions of the table to coordinate to prevent write and do
> flush at the same time. Since we use WALPlayer to complete the data that is
> not in the snapshot HFile, we don't need the snapshot to do coordinated
> flush. The snapshot just recored all the HFile that are already there.
> I added the parameter in the HBase shell. So people can choose to use the
> NoFlush snapshot when they need, like below. Otherwise, the default flush
> snpahot support is not impacted.
> >snaphot 'TestTable', 'TestSnapshot', 'skipFlush'
--
This message was sent by Atlassian JIRA
(v6.2#6252)
