[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012680#comment-14012680
]
Hadoop QA commented on HBASE-10336:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12647405/HBASE-10336-after-first-review.patch
against trunk revision .
ATTACHMENT ID: 12647405
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 48 new
or modified tests.
{color:red}-1 javac{color}. The applied patch generated 45 javac compiler
warnings (more than the trunk's current 4 warnings).
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ .append(isAlive() ? STATE_DESCRIPTION_ALIVE :
STATE_DESCRIPTION_NOT_LIVE).append("), listening at:");
+ private void writeAttribute(JsonGenerator jg, ObjectName oname,
MBeanAttributeInfo attr) throws IOException {
+ public static HttpServer createServer(String webapp, Configuration conf,
AccessControlList adminsAcl)
+ return
localServerBuilder(webapp).setFindPort(true).setConf(conf).setPathSpec(pathSpecs).build();
+ String serverURL = "http://"; +
NetUtils.getHostPortString(myServer.getConnectorAddress(0)) + "/";
+
Mockito.verify(response).sendError(Mockito.eq(HttpServletResponse.SC_UNAUTHORIZED),
Mockito.anyString());
+
Mockito.verify(response).sendError(Mockito.eq(HttpServletResponse.SC_UNAUTHORIZED),
Mockito.anyString());
+ assertTrue( e.getMessage().contains("Problem in starting http server.
Server handlers failed"));
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.crypto.aes.TestAES
org.apache.hadoop.hbase.TestHBaseConfiguration
org.apache.hadoop.hbase.TestClassFinder
org.apache.hadoop.hbase.util.TestCoprocessorClassLoader
org.apache.hadoop.hbase.io.crypto.TestKeyProvider
org.apache.hadoop.hbase.io.crypto.TestCipherProvider
org.apache.hadoop.hbase.io.crypto.TestEncryption
org.apache.hadoop.hbase.util.TestDynamicClassLoader
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9639//console
This message is automatically generated.
> Remove deprecated usage of Hadoop HttpServer in InfoServer
> ----------------------------------------------------------
>
> Key: HBASE-10336
> URL: https://issues.apache.org/jira/browse/HBASE-10336
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.99.0
> Reporter: Eric Charles
> Assignee: Eric Charles
> Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch,
> HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch,
> HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch,
> HBASE-10336-9.patch, HBASE-10336-after-first-review.patch,
> HBASE-10569-10.patch
>
>
> Recent changes in Hadoop HttpServer give NPE when running on hadoop
> 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
> not fixed (see HDFS-5760). We'd better move to the new proposed builder
> pattern, which means we can no more use inheritance to build our nice
> InfoServer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
