[
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015685#comment-14015685
]
Eric Charles commented on HBASE-10336:
--------------------------------------
[~stack] Trying to answer your points taking into account my last patch
uploaded on rb (also answered you comments on rb):
- no more conf package and interface instead of class - yep, we could put then
in server interface or hconstants - just wanted to mimick what hadoop does and
btw, a dedicated interface could make sense for http.
- 95% copy/paste from hadoop - pulled everyting related to http - Yes, we could
have left HtmlQuoting... in Hadoop, but this could lead later on to issues
(changes that we don't want, more difficult to inject changes...)
- hierarchy of InfoServer/HttpServer could be reviewed indeed.
The patch works.
Thx, Eric
> Remove deprecated usage of Hadoop HttpServer in InfoServer
> ----------------------------------------------------------
>
> Key: HBASE-10336
> URL: https://issues.apache.org/jira/browse/HBASE-10336
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.99.0
> Reporter: Eric Charles
> Assignee: Eric Charles
> Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch,
> HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch,
> HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch,
> HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch,
> HBASE-10336-after-first-review.patch, HBASE-10569-10.patch
>
>
> Recent changes in Hadoop HttpServer give NPE when running on hadoop
> 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be
> not fixed (see HDFS-5760). We'd better move to the new proposed builder
> pattern, which means we can no more use inheritance to build our nice
> InfoServer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
