[
https://issues.apache.org/jira/browse/HBASE-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013673#comment-14013673
]
Hadoop QA commented on HBASE-11263:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12647586/HBASE-11263-trunk-v1.diff
against trunk revision .
ATTACHMENT ID: 12647586
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9649//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9649//console
This message is automatically generated.
> Share the open/close store file thread pool for all store in a region
> ---------------------------------------------------------------------
>
> Key: HBASE-11263
> URL: https://issues.apache.org/jira/browse/HBASE-11263
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.99.0
> Reporter: Liu Shaohui
> Assignee: Liu Shaohui
> Priority: Minor
> Attachments: HBASE-11263-trunk-v1.diff
>
>
> Currently, the open/close store file thread pool is divided equally to all
> stores of a region.
> {code}
> protected ThreadPoolExecutor getStoreFileOpenAndCloseThreadPool(
> final String threadNamePrefix) {
> int numStores = Math.max(1, this.htableDescriptor.getFamilies().size());
> int maxThreads = Math.max(1,
> conf.getInt(HConstants.HSTORE_OPEN_AND_CLOSE_THREADS_MAX,
> HConstants.DEFAULT_HSTORE_OPEN_AND_CLOSE_THREADS_MAX)
> / numStores);
> return getOpenAndCloseThreadPool(maxThreads, threadNamePrefix);
> }
> {code}
> This is not very optimal in following scenarios:
> # The data of some column families are very large and there are many hfiles
> in those stores, and others may be very small and in-memory column families.
> # Usually we preserve some column families for later needs. The thread pool
> for these column families are wasted。
> The simple way is to share a big thread pool for all stores to open/close
> hfiles.
> Suggestions are welcomed.
> Thanks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
