[
https://issues.apache.org/jira/browse/HBASE-11298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017887#comment-14017887
]
Andrew Purtell commented on HBASE-11298:
----------------------------------------
+1
I would leave this hunk out of a 0.98 patch:
{code}
--- hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
+++ hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
@@ -144,9 +144,7 @@ import com.google.protobuf.TextFormat;
*/
@InterfaceAudience.Private
public class RpcServer implements RpcServerInterface {
- // The logging package is deliberately outside of standard o.a.h.h package
so it is not on
- // by default.
- public static final Log LOG =
LogFactory.getLog("org.apache.hadoop.ipc.RpcServer");
+ public static final Log LOG = LogFactory.getLog(RpcServer.class);
private final boolean authorize;
private boolean isSecurityEnabled;
{code}
> Simplification in RpcServer code
> --------------------------------
>
> Key: HBASE-11298
> URL: https://issues.apache.org/jira/browse/HBASE-11298
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.99.0
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Fix For: 0.99.0
>
> Attachments: 11298.v1.patch
>
>
> No important changes here, but I'm doing some other changes on top of this
> (typically HBASE-11297)
>
> Note that I've changed the logs, they now belong to the "real" class instead
> of hijacking Hadoop. I suppose it was historical, but it was as well very
> confusing.
--
This message was sent by Atlassian JIRA
(v6.2#6252)